Skip to content

refactor: replace javax Nullable with jakarta Nullable in MenuItemDto#146

Merged
mlopezFC merged 4 commits intomasterfrom
vaadin-25
Dec 23, 2025
Merged

refactor: replace javax Nullable with jakarta Nullable in MenuItemDto#146
mlopezFC merged 4 commits intomasterfrom
vaadin-25

Conversation

@javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Dec 23, 2025 •
edited by coderabbitai bot
Loading

Close #145

Summary by CodeRabbit

  • Chores
    • Bumped project version to 6.2.0-SNAPSHOT.
    • Updated Vaadin framework to stable 25.0.0 (from beta 25.0.0-beta2).
    • Removed external repository dependency.

✏️ Tip: You can customize this high-level summary in your review settings.

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 23, 2025 •
edited
Loading

Walkthrough

The PR updates the project to version 6.2.0-SNAPSHOT, upgrades Vaadin from 25.0.0-beta2 to 25.0.0 stable, removes an external repository, and migrates MenuItemDto from deprecated javax.annotation to jakarta.annotation to resolve Vaadin 25 compatibility issues.

Changes

Cohort / File(s) Summary
POM Configuration
pom.xml		 Version bumped to 6.2.0-SNAPSHOT; Vaadin version updated from 25.0.0-beta2 to 25.0.0 in both global properties and v25 profile; FlowingCode Releases repository removed
Jakarta Annotation Migration
src/main/java/.../endpoint/MenuItemDto.java		 Copyright year updated to 2025; javax.annotation.Nullable import replaced with jakarta.annotation.Nullable

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Possibly related PRs

  • Update to 24.4.4 #122: Related POM and MenuItemDto.java import modifications affecting same files and dependency configuration

Suggested reviewers

  • paodb

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Out of Scope Changes check ⚠️ Warning The PR includes out-of-scope changes: version bump (6.1.1 to 6.2.0), Vaadin version upgrade (25.0.0-beta2 to 25.0.0), and repository removal, which exceed the scope of fixing the compilation issue. Consider separating packaging/configuration changes into a distinct PR focused solely on the javax-to-jakarta import replacement to address issue #145.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: replacing javax.annotation.Nullable with jakarta.annotation.Nullable in MenuItemDto, which aligns with the primary objective of fixing Vaadin 25 compilation failure.
Linked Issues check ✅ Passed The PR successfully addresses issue #145 by replacing javax.annotation.Nullable with jakarta.annotation.Nullable in MenuItemDto, which resolves the compilation failure for Vaadin 25.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
  • 📝 Generate docstrings
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch vaadin-25
📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 9f5bee7 and 8eb8f66.

📒 Files selected for processing (2)
  • pom.xml
  • src/main/java/com/flowingcode/addons/applayout/endpoint/MenuItemDto.java
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (2)
  • GitHub Check: build-vaadin24
  • GitHub Check: build-vaadin25
🔇 Additional comments (4)
src/main/java/com/flowingcode/addons/applayout/endpoint/MenuItemDto.java (2)

5-5: LGTM: Copyright year updated.

Standard housekeeping to keep the copyright year current.

25-25: Import migration to jakarta.annotation is complete and properly configured.

The migration from javax.annotation to jakarta.annotation.Nullable is verified as complete—no remaining javax.annotation imports exist in the codebase. The jakarta.annotation-api dependency is correctly provided transitively through Vaadin's BOM when using the v25 profile (which sets Vaadin 25.0.0).

pom.xml (2)

7-7: LGTM: Appropriate version bump.

The minor version increment from 6.1.1-SNAPSHOT to 6.2.0-SNAPSHOT is appropriate for the Jakarta annotation migration, signaling a change that may require consumers to update their dependencies.

533-533: Vaadin 25.0.0 upgrade in v25 profile is valid; no additional verification needed.

The update from Vaadin 25.0.0-beta2 to 25.0.0 stable is straightforward. The code already imports jakarta.annotation.Nullable (MenuItemDto.java line 25), and this dependency is transitive from the Vaadin/Hilla BOM—no explicit jakarta.annotation-api declaration is required. Both Vaadin 24.4.4 (default profile) and Vaadin 25.0.0 (v25 profile) provide this transitively, so compatibility between the two build configurations is not an issue for this change alone.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 23, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

mlopezFC
mlopezFC approved these changes Dec 23, 2025
View reviewed changes
Copy link
Member

@mlopezFC mlopezFC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mlopezFC mlopezFC merged commit 20ed6af into master Dec 23, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from To Do to Pending release in Flowing Code Addons Dec 23, 2025
@mlopezFC mlopezFC deleted the vaadin-25 branch December 23, 2025 14:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mlopezFC mlopezFC mlopezFC approved these changes

Assignees

No one assigned

Labels

None yet

Projects

Flowing Code Addons
Status: Pending release

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Vaadin 25: Compilation failure (package javax.annotation does not exist)

2 participants

@javier-godoy @mlopezFC